tree fa23068d6e552e1111952333c8135a6dad8e77a2
parent 0084168af8481ecacedae9b627908fb0a96c6bbe
author Joe Tsai <joetsai@digital-static.net> 1592330769 -0700
committer Joe Tsai <joetsai@digital-static.net> 1592334800 +0000

reflect/protoreflect: optimize Name.IsValid and FullName.IsValid

For simplicity, IsValid was implemented in terms of regular expressions,
which are useful for verifying a string according to a strict grammar,
but performs poorly. Implement the check in terms of hand-written code,
which provides a 20x improvement to validate the name "google.protobuf.Any".

name               old time/op  new time/op  delta
FullNameIsValid-8   683ns ± 2%    35ns ± 1%  -94.86%  (p=0.000 n=10+10)

Change-Id: I980403befca0b72cea22acd274064a46cb02644b
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/238002
Reviewed-by: Damien Neil <dneil@google.com>