| commit | 44000a1bea5e5eee0c7438110057617822b3850f | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Wed Oct 24 12:31:16 2018 -0700 |
| committer | Damien Neil <dneil@google.com> | Wed Oct 24 19:46:45 2018 +0000 |
| tree | ee0664394fd2f2dff6d40a213a30bc11fca246e7 | |
| parent | ad8ee05d0e32c138cc4531bbca64747ab34aedcb [diff] |
cmd/protoc-gen-go: treat extensions fields as proto2 in some places The v1 generator doesn't include a "proto3" tag on extension fields, even when the field is defined in a proto3 file. Match that behavior for consistency. We can probably change this later if we want to; it's unlikely anyone is depending on this behavior. The v1 generator uses pointer types for extension fields, even when the field is defined in a proto3 file. (e.g., *FooEnum instead of FooEnum.) Match this behavior. We can't change this without breaking compatibility in the generated code. Change-Id: I4072f3dd1c915bf9ab89f1d5198e0144cb4de20f Reviewed-on: https://go-review.googlesource.com/c/144282 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.