Google Git
Sign in
go / protobuf / 3d0706ac2e40495e56815f8d86b07077bc207eb3
commit3d0706ac2e40495e56815f8d86b07077bc207eb3[log] [tgz]
authorDamien Neil <dneil@google.com>Tue Jul 09 11:40:49 2019 -0700
committerDamien Neil <dneil@google.com>Tue Jul 09 19:49:22 2019 +0000
tree8d2a0e2ccfd69d373470321918f7f7480bb8aa7c
parentdd380ab64d25a7a7bc4aa94ea1a1d43d396ba4f3 [diff]
proto, internal/impl: make IsInitialized more consistent

Make the fast-path and slow-path versions of IsInitialized report
exactly the same errors: An errors.RequiredNotSet containing the
full name of one of the unset required fields.

Bugfix: Fast-path IsInitialized on a nil message reports an error only
when the message directly contains required fields.

Bugfix: Include fast-path IsInitialized in legacy messageIfaceWrapper.

Fixes golang/protobuf#887

Change-Id: Ia5e4b386f8c23f6f855d995f4a098b1338acbae3
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185397
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
6 files changed
tree: 8d2a0e2ccfd69d373470321918f7f7480bb8aa7c
  1. benchmarks/
  2. cmd/
  3. compiler/
  4. encoding/
  5. internal/
  6. proto/
  7. reflect/
  8. runtime/
  9. testing/
  10. types/
  11. .gitignore
  12. .travis.yml
  13. AUTHORS
  14. CONTRIBUTING.md
  15. CONTRIBUTORS
  16. download_benchdata.bash
  17. go.mod
  18. go.sum
  19. integration_test.go
  20. LICENSE
  21. PATENTS
  22. README.md
  23. regenerate.bash
  24. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.