Google Git
Sign in
go / protobuf / 34eb7ef6d5127078404b6d6ae5ef8fc6b4b25984
commit34eb7ef6d5127078404b6d6ae5ef8fc6b4b25984[log] [tgz]
authorJoe Tsai <joetsai@digital-static.net>Wed Nov 07 16:39:49 2018 -0800
committerJoe Tsai <thebrokentoaster@gmail.com>Thu Nov 08 02:34:04 2018 +0000
tree4ef750f56d8aa47eaa762b20240436cc9929274a
parent1795eb16a4a234d23b536d9423f9c244690569a7 [diff]
reflect/protoreflect: clarify Clear and Remove operation on missing entries

Follow the precedence of Go maps where deletion on a key without an entry in
the map is a noop. Similarly, document that the following methods are safe
to call with entries that do not exist:
* Map.Clear
* KnownFields.Clear
* ExtensionFieldTypes.Remove

Change the implementation for each of these to match the documented behavior.

Change-Id: Ifccff9b7b03baaeffdc366d05f6286ba60e14934
Reviewed-on: https://go-review.googlesource.com/c/148317
Reviewed-by: Herbie Ong <herbie@google.com>
2 files changed
tree: 4ef750f56d8aa47eaa762b20240436cc9929274a
  1. cmd/
  2. internal/
  3. protogen/
  4. reflect/
  5. .gitignore
  6. .travis.yml
  7. AUTHORS
  8. CONTRIBUTING.md
  9. CONTRIBUTORS
  10. go.mod
  11. go.sum
  12. LICENSE
  13. PATENTS
  14. README.md
  15. regenerate.bash
  16. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.