tree 4678493d06883a106cff2eb2e773f8ed6a6d9555
parent 6238696abc44f545a152cc43e4e0161e8ae61afd
author Joe Tsai <joetsai@digital-static.net> 1540804242 -0700
committer Joe Tsai <thebrokentoaster@gmail.com> 1541011194 +0000

internal/impl: use linked-list for unknown field ordering

Unknown fields follow a policy where the latest field takes precedence when
it comes to the ordering. However, the current implementation is incorrect
as it uses a slice and simply swaps the current entry with the last entry.
While this ensures that the latest field seen remains last, it does not ensure
that the swapped out entry is second-to-last.

To provide the desired behavior, a linked-list is used.
For simplicity, we use the list package in the standard library even if it
is neither the most performant nor type safe.

Change-Id: I675145c61f6b5b624ed9e94bbe2251b5a71e2c48
Reviewed-on: https://go-review.googlesource.com/c/145241
Reviewed-by: Damien Neil <dneil@google.com>