| commit | 6238696abc44f545a152cc43e4e0161e8ae61afd | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Tue Oct 30 10:35:48 2018 -0700 |
| committer | Damien Neil <dneil@google.com> | Tue Oct 30 18:46:20 2018 +0000 |
| tree | 5c84290c330d24cdf2a7606070f07b6447a54344 | |
| parent | 6b54131a8912427da470258ff5ce9570b56c72ac [diff] |
cmd/protoc-gen-go: replicate v1 generator behavior for MessageSet extensions
Given:
package foo
extend proto2.bridge.MessageSet {
optional Message message_set_extension = 100;
}
Register the extension as a message set extension and give it the name
"foo.".
We really shouldn't do this in this case; the special-case treatment of
extensions to MessageSet is only for extensions nested in a parent
message. However, this is consistent with the behavior of the v1 generator.
Match that for now.
Change-Id: I919c409605a197904fd3227efc920192d484f431
Reviewed-on: https://go-review.googlesource.com/c/145957
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.