| commit | 2d5a169f75bae6f3a95a970044650a2c39873171 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Mon Oct 29 02:10:42 2018 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Wed Oct 31 18:39:54 2018 +0000 |
| tree | 4678493d06883a106cff2eb2e773f8ed6a6d9555 | |
| parent | 6238696abc44f545a152cc43e4e0161e8ae61afd [diff] |
internal/impl: use linked-list for unknown field ordering Unknown fields follow a policy where the latest field takes precedence when it comes to the ordering. However, the current implementation is incorrect as it uses a slice and simply swaps the current entry with the last entry. While this ensures that the latest field seen remains last, it does not ensure that the swapped out entry is second-to-last. To provide the desired behavior, a linked-list is used. For simplicity, we use the list package in the standard library even if it is neither the most performant nor type safe. Change-Id: I675145c61f6b5b624ed9e94bbe2251b5a71e2c48 Reviewed-on: https://go-review.googlesource.com/c/145241 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.