tree d4f315cef7145d4d8eac58b63063eeb6cd6684b5
parent 7c624e2501b551c1b59e88028c95d3ddba001ec2
author Joe Tsai <joetsai@digital-static.net> 1544755045 -0800
committer Joe Tsai <joetsai@digital-static.net> 1544812252 +0000

protogen: simplify and fix naming derivation logic

We want to codify the naming logic to be understandable in a specification.
Clean up the camelCase function to be a little more readable.

Cleanup and fix the cleanGoName function when mustExport is true.
It is okay to change this behavior since this is new logic in v2 that has not
yet been exposed to the universe.

In the mustExport code-path, we do not need to check for conflicts with keywords
since Go keywords are never uppercase, so the uppercasing of the first letter
is sufficient to break a conflict. Also, we fix the logic for uppercasing
the first character since not every lowercase character has an uppercase form.

Change-Id: If14422d773bb89ed7038d874135e3dcd12683101
Reviewed-on: https://go-review.googlesource.com/c/154180
Reviewed-by: Damien Neil <dneil@google.com>