| commit | 2c6f09887db88e2caf7ba16d4e3976359bb219ce | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Thu Dec 13 18:37:25 2018 -0800 |
| committer | Joe Tsai <joetsai@digital-static.net> | Fri Dec 14 18:30:52 2018 +0000 |
| tree | d4f315cef7145d4d8eac58b63063eeb6cd6684b5 | |
| parent | 7c624e2501b551c1b59e88028c95d3ddba001ec2 [diff] |
protogen: simplify and fix naming derivation logic We want to codify the naming logic to be understandable in a specification. Clean up the camelCase function to be a little more readable. Cleanup and fix the cleanGoName function when mustExport is true. It is okay to change this behavior since this is new logic in v2 that has not yet been exposed to the universe. In the mustExport code-path, we do not need to check for conflicts with keywords since Go keywords are never uppercase, so the uppercasing of the first letter is sufficient to break a conflict. Also, we fix the logic for uppercasing the first character since not every lowercase character has an uppercase form. Change-Id: If14422d773bb89ed7038d874135e3dcd12683101 Reviewed-on: https://go-review.googlesource.com/c/154180 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.