| commit | 2aea614c5eed1edc254edd3321506f4014191150 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Wed Jul 31 12:27:30 2019 -0700 |
| committer | Joe Tsai <joetsai@digital-static.net> | Mon Aug 05 21:22:56 2019 +0000 |
| tree | 113905bde1daea0b359d2adb92436490975e1c07 | |
| parent | d57568e76382c742a0e0afbf389ea0acc246ee32 [diff] |
internal/impl: fix race over messageState.mi The messageState.mi field is atomically checked and set in generated code to the *MessageInfo associated with that message. However, the messageState type accesses the mi field without any atomic loads, thus being a potential race. We fix this by always calling a messageInfo method that performs a atomic.LoadPointer on the *MessageInfo. There is no performance effect from this change on x86 since an atomic.LoadPointer is identical to a MOV instruction. From an assembly perspective, there was no memory race previously. However, the lack of an atomic.LoadPointer meant that the compiler could in theory reorder the "normal" load to produce truly racy code. Change-Id: I8afefaf35c1916872781abc0239cbb63d62edf16 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/189017 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.