commit | 28e61ba70b5780ea47d88e6e253f98e6face87e4 | [log] [tgz] |
---|---|---|
author | Joe Tsai <joetsai@digital-static.net> | Mon Jul 01 14:33:20 2019 -0700 |
committer | Joe Tsai <thebrokentoaster@gmail.com> | Mon Jul 01 21:51:21 2019 +0000 |
tree | ed02140eb61beaaec1499ae2889c74243404c688 | |
parent | 851185dae30adae2f3ae7a7ce1df7454af1abe7e [diff] |
internal/impl: drop XXX_MessageName aberrant support The aberrant support logic only has access to the Go type information, and not a concrete value. However, the XXX_MessageName method exists on some hacky dynamic proto implementations where it is only valid to call on a concrete value, not just newly created instance of the given type. However, from the perspective of the support logic, it is impossible to distinguish between dynamic messages and hand-crafted custom messages. Thus, just drop support for XXX_MessageName. We won't get the full name of the message right, but oh well, what can we do. Change-Id: Icc272861e11a355639fb82a991ca2854a9edc0c7 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/184557 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2:
prefix in the title to make it clear that the issue is regarding the new API work.