|author||Joe Tsai <email@example.com>||Tue Dec 04 22:53:56 2018 -0800|
|committer||Joe Tsai <firstname.lastname@example.org>||Thu Dec 06 17:47:27 2018 +0000|
cmd/protoc-gen-go: generate descriptor and plugin with reflection In CL/152020, we checked in pre-generated versions of descriptor and plugin. This CL makes it such that they are generated by protoc-gen-go. We modify protoc-gen-go to avoid reflection support by default since the binary size increase is still an issue to investigate. Reflection support is temporarily enabled by setting a special PROTOC_GEN_GO_ENABLE_REFLECT environment variable. Reflection support is always enabled for descriptor and plugin. Furthermore, we change descriptor to depend on the protoapi package instead of the proto package. The reason we do not switch to protoapi for all generated protos is because we still depend on v1 proto for the table-driven InternalMessageInfo type. Dropping it from descriptor is semantically correct, but does incur slight performance cost. It does not seem appropriate to drop it for all generated messages. We could move InternalMessageInfo to protoapi, but the logic behind that is significant. Change-Id: I5c3fff7f6eab1a5a2399049d42fa6bf42d4c93f9 Reviewed-on: https://go-review.googlesource.com/c/152547 Reviewed-by: Damien Neil <email@example.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a
APIv2: prefix in the title to make it clear that the issue is regarding the new API work.