tree d1c4caa4857aa19318d1132efe5749aa6467a6e9
parent 692690ff4e033fc7535b55fea393000f3367d29c
author Damien Neil <dneil@google.com> 1544483676 -0800
committer Damien Neil <dneil@google.com> 1544559945 +0000

reflect/prototype: hoist semantic options into builders

Add fields to the Message and Field builder structs which hold the value
of MessageOptions.map_entry, FieldOptions.packed, and FieldOptions.weak
options. Remove all access to the contents of options messages from the
prototype package.

Change IsPacked to always return false for unpackable field types,
which is consistent with the equivalent C++ API.

This change helps avoid dependency cycles between prototype and the
options messages. (Previously this was resolved by accessing options
with reflection, but just breaking the dependency from prototype to the
options message is cleaner and simpler.)

Change-Id: I756aefe2e04cfa8fea31eaaaa0b5a99d4ac9e851
Reviewed-on: https://go-review.googlesource.com/c/153517
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>