| commit | 232ea15589f6db45454e569c5cdf29eab7c7a7cd | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Mon Dec 10 15:14:36 2018 -0800 |
| committer | Damien Neil <dneil@google.com> | Tue Dec 11 20:25:45 2018 +0000 |
| tree | d1c4caa4857aa19318d1132efe5749aa6467a6e9 | |
| parent | 692690ff4e033fc7535b55fea393000f3367d29c [diff] |
reflect/prototype: hoist semantic options into builders Add fields to the Message and Field builder structs which hold the value of MessageOptions.map_entry, FieldOptions.packed, and FieldOptions.weak options. Remove all access to the contents of options messages from the prototype package. Change IsPacked to always return false for unpackable field types, which is consistent with the equivalent C++ API. This change helps avoid dependency cycles between prototype and the options messages. (Previously this was resolved by accessing options with reflection, but just breaking the dependency from prototype to the options message is cleaner and simpler.) Change-Id: I756aefe2e04cfa8fea31eaaaa0b5a99d4ac9e851 Reviewed-on: https://go-review.googlesource.com/c/153517 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.