Google Git
Sign in
go / protobuf / 22b1ebd06807a76fa5e9fefd8f805ea1e27aad3d
commit22b1ebd06807a76fa5e9fefd8f805ea1e27aad3d[log] [tgz]
authorJoe Tsai <joetsai@digital-static.net>Mon Mar 11 13:45:14 2019 -0700
committerJoe Tsai <thebrokentoaster@gmail.com>Mon Mar 11 21:23:31 2019 +0000
tree0f580c83fae8f7910af7cd60eaffaa7d66a597aa
parentc93f494f4a06d8a4acb050299cd83f058e622fac [diff]
internal/impl: split messageWrapper into different types

The previous implementation of messageWrapper implemented both
proto.Message and protoreflect.Message. This made it possible for users
to accidentally rely on this fact when it was actually an internal
implementation detail.

To avoid this, we split the wrapper type into two, ensuring that each
only implements one or the other. Doing so also revealed bugs in our
own code where we accidentally relied on this fact.

Change-Id: I0ff521b5c806b7dcb0b86942bd97e8319d8e8657
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/166938
Reviewed-by: Damien Neil <dneil@google.com>
2 files changed
tree: 0f580c83fae8f7910af7cd60eaffaa7d66a597aa
  1. cmd/
  2. encoding/
  3. internal/
  4. proto/
  5. protogen/
  6. reflect/
  7. runtime/
  8. types/
  9. .gitignore
  10. .travis.yml
  11. AUTHORS
  12. CONTRIBUTING.md
  13. CONTRIBUTORS
  14. go.mod
  15. go.sum
  16. integration_test.go
  17. LICENSE
  18. PATENTS
  19. README.md
  20. regenerate.bash
  21. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.