| commit | 42fa50da346db96fd93024197797927c8a5d32a9 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Mon Oct 15 17:34:43 2018 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Tue Oct 16 16:49:18 2018 +0000 |
| tree | d7acdb66eece12b420106debd016b0d207c36c1d | |
| parent | a85e9569ed74a563fa754ef6f7731c833f1796e3 [diff] |
test.bash: do not run golden tests by default The golden tests are sensitive to the exact version used: * Protobuf toolchain since the generated Descriptor is dependendent on protoc (for example, default json_names were auto-populated in later versions of protoc) * Go toolchain since the generated .pb.go files is dependent on the exact output of gofmt and the gzip compression used. There are other areas where it depends on unstable output, but the above are the major causes. Since test.bash ensures that the golden tests are run with exact versions of the protobuf and Go toolchains, we can ensure that the tests are reproducible across different developer workstations. Thus, we add a "golden" build tag to disable them for normal invocations of "go test ./..." and only run them if test.bash is run. If test.bash is ever updated with newer versions, the golden testdata can be updated at the same time. Change-Id: Ia2b7b039aad2ddaef7652e332215bf9403a6d856 Reviewed-on: https://go-review.googlesource.com/c/142458 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.