Google Git
Sign in
go / protobuf / 20aefe9c5e425a7949e845ed5f3cc152d2130eb6
commit20aefe9c5e425a7949e845ed5f3cc152d2130eb6[log] [tgz]
authorHerbie Ong <herbie@google.com>Mon Jun 24 19:21:46 2019 -0700
committerHerbie Ong <herbie@google.com>Tue Jun 25 21:57:50 2019 +0000
treeea0535be2dc9627b75cbc2a903e2b8cfecba813c
parenta7f7a409cb650453d1a344401e2922e6b9ce1711 [diff]
encoding/prototext: fix parsing of field names

Previous code tries to do all-lowercase match all non-extension field
names to match group field names, which is incorrect. Fix to check for
only group field type and make sure that the format is correct as well.

Fixes golang/protobuf#878.

Fix typo in text proto string in internal/impl/message_test.go that
wasn't caught before due to above issue.

Change-Id: Ief952907306435ed76a095e96e29fcc9c0027b73
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183737
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
3 files changed
tree: ea0535be2dc9627b75cbc2a903e2b8cfecba813c
  1. benchmarks/
  2. cmd/
  3. compiler/
  4. encoding/
  5. internal/
  6. proto/
  7. reflect/
  8. runtime/
  9. testing/
  10. types/
  11. .gitignore
  12. .travis.yml
  13. AUTHORS
  14. CONTRIBUTING.md
  15. CONTRIBUTORS
  16. download_benchdata.bash
  17. go.mod
  18. go.sum
  19. integration_test.go
  20. LICENSE
  21. PATENTS
  22. README.md
  23. regenerate.bash
  24. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.