| commit | 17523ebe6766434bd6bffcb79145e76f6326a0d3 | [log] [tgz] |
|---|---|---|
| author | Herbie Ong <herbie@google.com> | Fri Mar 29 17:46:57 2019 -0700 |
| committer | Herbie Ong <herbie@google.com> | Tue Apr 02 05:00:42 2019 +0000 |
| tree | e6f33fee4f64b8cc249d05b5ca94b626f820c7a6 | |
| parent | 300b9fe4da144191805fcaed9885959f69457170 [diff] |
encoding/jsonpb: improve and fix unmarshaling of Duration Change use of regular expression to manually parsing the value. Allow value with + symbol in front, e.g. "+3s". Previous regex missed this. Do not allow values without numbers, e.g. "-s". Previous regex missed this as well. name old time/op new time/op delta Unmarshal_Duration-4 1.96µs ± 0% 1.24µs ± 0% ~ (p=1.000 n=1+1) name old alloc/op new alloc/op delta Unmarshal_Duration-4 703B ± 0% 512B ± 0% ~ (p=1.000 n=1+1) name old allocs/op new allocs/op delta Unmarshal_Duration-4 20.0 ± 0% 17.0 ± 0% ~ (p=1.000 n=1+1) Change-Id: I4db58d70f55607213631c49d698ee6a048b5e094 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/170012 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.