| commit | 08e003003298ae196e8cdbecc6e98a17dac37010 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Mon Nov 26 22:32:06 2018 -0800 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Fri Nov 30 23:16:16 2018 +0000 |
| tree | 5a9f1acc818e333e32b775b8cda39ebc54864680 | |
| parent | ba0ef9a5719849b3057e99f0b0aeadeb11823126 [diff] |
internal/legacy: extract legacy support out from the impl package The impl package currently supports wrapping legacy v1 enums and messages so that they implement the v2 reflective APIs. This functionality is necessary for v1 and v2 to interoperate. However, the existence of this functionality presents several problems: * A significant portion of the complexity in impl is for legacy wrapping. * This complexity is linked into a Go binary even if all the other messages in the binary natively support v2 reflection. * It presents a cyclic dependency when trying to generate descriptor proto. Suppose you are generating descriptor.proto. The generated code would want to depend on the impl package because impl is the runtime implementation for protobuf messages. However, impl currently depends depends on descriptor in order to wrap legacy enum and messages since it needs the ability to dynamically create new protobuf descriptor types. In the case of descriptor.proto, it would presumably be generated with native reflection support, so the legacy wrapping logic is unneccessary. To break the dependency of impl on descriptor, we move the legacy support logic to a different package and instead add hooks in impl so that legacy support could be dynamically registered at runtime. This is dependency injection. Change-Id: I01a582908ed5629993f6699e9bf2f4bee93857a4 Reviewed-on: https://go-review.googlesource.com/c/151877 Reviewed-by: Herbie Ong <herbie@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.