Google Git
Sign in
go / protobuf / 17581daabb23b79bce23d11363941662ba409f7e
commit17581daabb23b79bce23d11363941662ba409f7e[log] [tgz]
authorJoe Tsai <joetsai@digital-static.net>Thu Aug 08 17:18:32 2019 -0700
committerJoe Tsai <joetsai@digital-static.net>Thu Aug 15 22:18:29 2019 +0000
tree93d4a284eb351709ac153ab4f8af58505c4f3c66
parent16163b4f675b9ced03abc9157069d5dc76762213 [diff]
cmd/protoc-gen-go: fix struct tag formatting

If a string default value contains a backtick, it breaks the
struct tag formatting logic which assumes such characters never exist.
Fix this by adding a structTags type, whose String method knows how
to properly escape the value.

Change-Id: I96fe5a6630387eac89eef429da5f917125570e4c
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/189557
Reviewed-by: Herbie Ong <herbie@google.com>
3 files changed
tree: 93d4a284eb351709ac153ab4f8af58505c4f3c66
  1. benchmarks/
  2. cmd/
  3. compiler/
  4. encoding/
  5. internal/
  6. proto/
  7. reflect/
  8. runtime/
  9. testing/
  10. types/
  11. .gitignore
  12. .travis.yml
  13. AUTHORS
  14. CONTRIBUTING.md
  15. CONTRIBUTORS
  16. go.mod
  17. go.sum
  18. integration_test.go
  19. LICENSE
  20. PATENTS
  21. README.md
  22. regenerate.bash
  23. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.