commit | 0757b4eacee46aad9fd6cfbe2ec359fbd92cd316 | [log] [tgz] |
---|---|---|
author | Dmitri Shuralyov <dmitshur@golang.org> | Fri Aug 17 19:58:32 2018 -0400 |
committer | Dmitri Shuralyov <dmitshur@golang.org> | Sat Aug 18 01:29:44 2018 +0000 |
tree | d22387d7e4a61e40ac5eb70b5173df8b10d5a96c | |
parent | 06ce2e1b0a3d69017cda90da23ff733bcc8de783 [diff] |
playground: serve 404 for non-existent pages The server.handleEdit handler is being registered to handle the "/" pattern. Its code checks if the request URL path has a "/p/" prefix, and otherwise assumes it's the index page. There's no check if it's some other unsupported URL. As a result, any URL that isn't handled elsewhere serves the index page. For example: https://play.golang.org/foobarbaz This change fixes that so non-existent pages return a 404 Not Found error instead. Also use context.Background() instead of a nil context in a test, per the context package instructions. Change-Id: I4c43492397a6f71bffc1e6a657ff2a523a245f94 Reviewed-on: https://go-review.googlesource.com/129795 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This subrepository holds the source for the Go playground: https://play.golang.org/
# build the image docker build -t playground .
docker run --name=play --rm -d -p 8080:8080 playground # run some Go code cat /path/to/code.go | go run client.go | curl -s --upload-file - localhost:8080/compile
gcloud --project=golang-org --account=person@example.com app deploy app.yaml
To submit changes to this repository, see https://golang.org/doc/contribute.html.