Google Git
Sign in
go / playground / 195e12f972a86a872472302af65f1e295e4eab74
commit195e12f972a86a872472302af65f1e295e4eab74[log] [tgz]
authorAlexander Rakoczy <alex@golang.org>Sat Apr 25 10:41:02 2020 -0400
committerAlexander Rakoczy <alex@golang.org>Mon Apr 27 17:58:39 2020 +0000
tree6ee1ec8c14bb59635c352a97bec714b7a928fcf1
parent560694fe2be3366074d38664c0e1b5ef5e5259b2 [diff]
sandbox: reduce container starvation

Creating a container in the sandbox takes 500ms to 1s. The sandbox was
creating containers serially, but serving requests in parallel. This
means that we can be starved for workers with a trivial number of
requests.

In addition, the sandbox in production is not CPU bound, meaning we
probably have room to do some extra work while serving a request.

This CL introduces a worker pool to create containers. It also changes
the readyContainer chan to unbuffered to avoid having twice as many
containers as we expect while idle (the container waiting to be sent
plus those already in the channel's buffer).

Updates golang/go#25224
Updates golang/go#38530

Change-Id: I0e535cf65409c3dbf32329577a1c0687c2614a0d
Reviewed-on: https://go-review.googlesource.com/c/playground/+/229981
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
1 file changed
tree: 6ee1ec8c14bb59635c352a97bec714b7a928fcf1
  1. cmd/
  2. deploy/
  3. examples/
  4. internal/
  5. sandbox/
  6. static/
  7. .gitignore
  8. app.yaml
  9. AUTHORS
  10. cache.go
  11. client.go
  12. codereview.cfg
  13. CONTRIBUTING.md
  14. CONTRIBUTORS
  15. Dockerfile
  16. edit.go
  17. edit.html
  18. enable-fake-time.patch
  19. fake_fs.lst
  20. fmt.go
  21. fmt_test.go
  22. go.mod
  23. go.sum
  24. LICENSE
  25. logger.go
  26. main.go
  27. Makefile
  28. PATENTS
  29. play.go
  30. play_test.go
  31. README.md
  32. sandbox.go
  33. sandbox_test.go
  34. server.go
  35. server_test.go
  36. share.go
  37. store.go
  38. tests.go
  39. txtar.go
  40. txtar_test.go
  41. vet.go
README.md

playground

This subrepository holds the source for the Go playground: https://play.golang.org/

Building

# build the image
docker build -t playground .

Running

docker run --name=play --rm -p 8080:8080 golang/playground &
# run some Go code
cat /path/to/code.go | go run client.go | curl -s --upload-file - localhost:8080/compile

Deployment

Deployment Triggers

Playground releases automatically triggered when new Go repository tags are pushed to GitHub, or when master is pushed on the playground repository.

For details, see deploy/go_trigger.json, deploy/playground_trigger.json, and deploy/deploy.json.

After making changes to trigger configuration, update configuration by running the following Make target:

make update-cloudbuild-trigger

Deploy via Cloud Build

The Cloud Build configuration will always build and deploy with the latest supported release of Go.

gcloud builds submit --config deploy/deploy.json .

Deploy via gcloud app deploy

Building the playground Docker container takes more than the default 10 minute time limit of cloud build, so increase its timeout first (note, app/cloud_build_timeout is a global configuration value):

gcloud config set app/cloud_build_timeout 1200  # 20 mins

Alternatively, to avoid Cloud Build and build locally:

make docker
docker tag golang/playground:latest gcr.io/golang-org/playground:latest
docker push gcr.io/golang-org/playground:latest
gcloud --project=golang-org --account=you@google.com app deploy app.yaml --image-url=gcr.io/golang-org/playground:latest

Then:

gcloud --project=golang-org --account=you@google.com app deploy app.yaml

Contributing

To submit changes to this repository, see https://golang.org/doc/contribute.html.