tree 469b8f5cd3eb3b88004b50e0db43990d7860c13a
parent f5ca8b02c596f0dce885c4d927344ee64cb5c22c
author Jonathan Amsterdam <jba@google.com> 1608587307 -0500
committer Jonathan Amsterdam <jba@google.com> 1608649783 +0000

internal/fetch: report DocTooLarge error in goPackage.err

loadPackage has two return values: a *goPackage and an error.

Before this CL, if a package's documentation was too large,
loadPackage would return the package and a non-nil error.

With this CL, that error is stored in the goPackage struct in a new
field, and loadPackage returns a nil error.

Aside from being more idiomatic, this change will enable future
changes needed to support multiple GOOS/GOARCH combinations.

For golang/go#37232

Change-Id: If73adde76239046eb22409659d6795c09bbb1fd4
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/279457
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>