tree bfa1cacc75d31aba1d7e02e588cb5c1e8f3c9748
parent 283cc4fc7c448e20db43ad20ae0a2899a2448cad
author Jonathan Amsterdam <jba@google.com> 1611608694 -0500
committer Jonathan Amsterdam <jba@google.com> 1611609583 +0000

internal/postgres: use series path in sort by latest

Using module path when sorting by the latest version can give the
wrong answer for some paths. Consider M/v9 and M/v10.  The latter is
obviously later, but sorting by module path descending before version
returns M/v9. But sometimes we do want to sort by the module path
first, as when we prefer an older version in a nested module to a
newer version outside. (See
TestGetUnitMeta/prefer_pubsublite_nested_module.)

If we sort by series path instead of module path handles both cases.
When looking for the latest major version of a given module, we select
for the series path, so sorting by series path is a no-op.  But the
series path correctly distinguishes nested modules from their parent
modules.

Fixes golang/go#43902

Change-Id: Icadab4ce2326f91ab3d3c81f46d17e482a2b9654
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/286452
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>