internal/vuln: display summary instead of description on package page
On package detail pages, use vulnerability summaries in place of longer
descriptions.
Change-Id: I6e67a5b408ab4eeb7e1ca3528eb1405315db3d39
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/507175
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
diff --git a/internal/frontend/search_test.go b/internal/frontend/search_test.go
index 55441e5..5c352ac 100644
--- a/internal/frontend/search_test.go
+++ b/internal/frontend/search_test.go
@@ -306,7 +306,8 @@
vulnEntries = []*osv.Entry{{
ID: "test",
- Details: "vuln",
+ Summary: "summary",
+ Details: "description",
Affected: []osv.Affected{{
Module: osv.Module{Path: "github.com/mod/foo"},
Ranges: []osv.Range{{
@@ -387,7 +388,7 @@
DisplayVersion: moduleFoo.Version,
Licenses: []string{"MIT"},
CommitTime: elapsedTime(moduleFoo.CommitTime),
- Vulns: []vuln.Vuln{{ID: "test", Details: "vuln"}},
+ Vulns: []vuln.Vuln{{ID: "test", Details: "summary"}},
},
},
},
diff --git a/internal/frontend/versions_test.go b/internal/frontend/versions_test.go
index ac6a33a..1ed90a5 100644
--- a/internal/frontend/versions_test.go
+++ b/internal/frontend/versions_test.go
@@ -92,7 +92,8 @@
vulnFixedVersion := "1.2.3"
vulnEntry := &osv.Entry{
ID: "GO-1999-0001",
- Details: "vuln",
+ Summary: "summary",
+ Details: "description",
Affected: []osv.Affected{{
Module: osv.Module{
Path: modulePath1,
@@ -151,7 +152,7 @@
vl := makeList(v1Path, modulePath1, "v1", []string{"v1.3.0", "v1.2.3", "v1.2.1"}, false)
vl.Versions[2].Vulns = []vuln.Vuln{{
ID: vulnEntry.ID,
- Details: vulnEntry.Details,
+ Details: vulnEntry.Summary,
}}
return vl
}(),
diff --git a/internal/vuln/vulns.go b/internal/vuln/vulns.go
index 05906eb..38c031f 100644
--- a/internal/vuln/vulns.go
+++ b/internal/vuln/vulns.go
@@ -67,7 +67,7 @@
for i, e := range entries {
vulns[i] = Vuln{
ID: e.ID,
- Details: e.Details,
+ Details: e.Summary,
}
}
diff --git a/tests/screentest/testdata/ci/vuln-stdlib-module-540x1080.a.png b/tests/screentest/testdata/ci/vuln-stdlib-module-540x1080.a.png
index 95c1fe2..c3ba6f5 100644
--- a/tests/screentest/testdata/ci/vuln-stdlib-module-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-stdlib-module-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-stdlib-module.a.png b/tests/screentest/testdata/ci/vuln-stdlib-module.a.png
index aebf1a2..4acaa0d 100644
--- a/tests/screentest/testdata/ci/vuln-stdlib-module.a.png
+++ b/tests/screentest/testdata/ci/vuln-stdlib-module.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-toolchain-module-540x1080.a.png b/tests/screentest/testdata/ci/vuln-toolchain-module-540x1080.a.png
index 3896d7e..b0c9cbb 100644
--- a/tests/screentest/testdata/ci/vuln-toolchain-module-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-toolchain-module-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-toolchain-module.a.png b/tests/screentest/testdata/ci/vuln-toolchain-module.a.png
index 8bc68b7..d21d6b7 100644
--- a/tests/screentest/testdata/ci/vuln-toolchain-module.a.png
+++ b/tests/screentest/testdata/ci/vuln-toolchain-module.a.png
Binary files differ
