| commit | 1c2626f1192a0cd5e124ea6f1c5a992519c6703c | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Wed May 20 11:29:38 2020 -0400 |
| committer | Jonathan Amsterdam <jba@google.com> | Thu May 21 16:06:22 2020 +0000 |
| tree | cca0a9c0b51f9c82fbf169f36842bb000fc77bd1 | |
| parent | a924a4ce832e44f9e31b0051415c703e454e9dfc [diff] |
internal/database: DB.Transact uses current context Use the context passed to Transact for the transaction. Previously, we used the background context, because that is what sql.DB.Begin does. But we should use the argument context. This is a behavior change, but it should be unnoticeable. All our transaction functions use the same context we pass to Transact, so the only difference this CL makes is that the DB calls in Transact itself, like BeginTx, Commit and Rollback, now have the potential to fail because the context is done. In practice that shouldn't matter. Change-Id: I5eeff51bcd28cb877e5288b83d9e08fa3d249482 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/750953 Reviewed-by: Julie Qiu <julieqiu@google.com>
Pkg.go.dev is a website for discovering and evaluting Go packages and modules.
Pkg.go.dev launched in November 2019, and is currently under active development by the Go team.
Our current goal is to work towards redirecting godoc.org traffic to pkg.go.dev, and ensure that we address users' needs in the process. Read more about our plans for pkg.go.dev in 2020.
We encourage everyone to begin using pkg.go.dev today for all of their needs and file feedback! You can redirect all of your requests from godoc.org to pkg.go.dev, by visiting godoc.org/?redirect=on. Details at Go issue #37099.
If you are having issues with pkg.go.dev, please first check the known issues before following the troubleshooting guide. If that does not give you the information you need, reach out to us.
You can chat with us on the #tools slack channel on the Gophers slack.
If you think you have an issue that needs fixing, or a feature suggestion, then please make sure you follow the steps to file an issue with the right information to allow us to address it.
We would love your help!
Our canonical Git repository is located cat go.googlesource.com/discovery. There is a mirror of the repository at github.com/golang/discovery.
To contribute, please read our contributing guide.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.