commit 18516de4f3037e65afa08fc83d2deb7a0e183597
author Michael Matloob <matloob@golang.org> Mon Aug 28 13:42:12 2023 -0400
committer Michael Matloob <matloob@golang.org> Tue Aug 29 23:29:27 2023 +0000
tree 9629a1666b5d24f8cc22848e7f306fa328853557
parent 4b63fb579b6b0d8364e29f19d83b35aba192df5b

internal/frontend: remove depsdev/result_count metric

go-discovery/depsdev/result_count doesn't seem to be used anywhere so
remove it.

For golang/go#61399

Change-Id: I253401d03bb1bfba4c569e45abfbf1d59a2a9b44
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/523512
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>

cmd/frontend/main.go

diff --git a/cmd/frontend/main.go b/cmd/frontend/main.go
index 38def44..72c63a7 100644
--- a/cmd/frontend/main.go
+++ b/cmd/frontend/main.go
@@ -186,7 +186,6 @@
 		middleware.CacheErrorCount,
 		middleware.CacheLatency,
 		middleware.QuotaResultCount,
-		frontend.DepsDevResultCount,
 	)
 	if err := dcensus.Init(cfg, views...); err != nil {
 		log.Fatal(ctx, err)

internal/frontend/depsdev.go

diff --git a/internal/frontend/depsdev.go b/internal/frontend/depsdev.go
index 1c3e9ad..5858608 100644
--- a/internal/frontend/depsdev.go
+++ b/internal/frontend/depsdev.go
@@ -13,9 +13,6 @@
 	"time"
 
 	"go.opencensus.io/plugin/ochttp"
-	"go.opencensus.io/stats"
-	"go.opencensus.io/stats/view"
-	"go.opencensus.io/tag"
 	"golang.org/x/pkgsite/internal"
 	"golang.org/x/pkgsite/internal/log"
 )
@@ -42,13 +39,10 @@
 		switch {
 		case errors.Is(err, context.Canceled):
 			log.Warningf(ctx, "fetching url from deps.dev: %v", err)
-			recordDepsDevMetric(ctx, "canceled")
 		case errors.Is(err, context.DeadlineExceeded):
 			log.Warningf(ctx, "fetching url from deps.dev: %v", err)
-			recordDepsDevMetric(ctx, "timeout")
 		case err != nil:
 			log.Errorf(ctx, "fetching url from deps.dev: %v", err)
-			recordDepsDevMetric(ctx, "error")
 		}
 		url <- u
 	}()
@@ -94,29 +88,3 @@
 	}
 	return depsDevBase + "/go/" + url.PathEscape(r.Name) + "/" + url.PathEscape(r.Version), nil
 }
-
-var (
-	keyDepsDevResult = tag.MustNewKey("depsdev.result")
-
-	depsDevResults = stats.Int64(
-		"go-discovery/depsdev_result_count",
-		"The result of fetching a deps.dev URL.",
-		stats.UnitDimensionless,
-	)
-
-	// DepsDevResultCount is a counter of results from fetching a URL from
-	// deps.dev: either OK, canceled, timeout, or error.
-	DepsDevResultCount = &view.View{
-		Name:        "go-discovery/depsdev/result_count",
-		Measure:     depsDevResults,
-		Aggregation: view.Count(),
-		Description: "deps.dev URL fetch results",
-		TagKeys:     []tag.Key{keyDepsDevResult},
-	}
-)
-
-func recordDepsDevMetric(ctx context.Context, kind string) {
-	stats.RecordWithTags(ctx, []tag.Mutator{
-		tag.Upsert(keyDepsDevResult, kind),
-	}, depsDevResults.M(1))
-}