| commit | b2adc7a90704b6fb3298e0f33ec63ea1866939b8 | [log] [tgz] |
|---|---|---|
| author | Zvonimir Pavlinovic <zpavlinovic@google.com> | Fri Jun 02 14:42:44 2023 -0700 |
| committer | Zvonimir Pavlinovic <zpavlinovic@google.com> | Sun Jun 04 02:28:15 2023 +0000 |
| tree | a2d02dce34562f76c68202862189bf86b508d3b4 | |
| parent | 303ca62a0721c61fe5a42058e6a10d51ec7dd2b8 [diff] |
all: correct removal of testing datasets In integration tests, we create test datasets that we try to delete once tests are done. This does not work since Delete() API we use expects datasets to be empty. We correct this by using an approprate API. Also, a test dataset is unique up to the current date (second precision), but if two tests are executed in parallel at the same second, this can lead to races. We now create datasets unique to the tests creating them. The major impact of this CL is that the target Cloud project will not accumulate test datasets that are of no use. Change-Id: Idf3dbbe6f16b9848e8f017c808605dbfebfc7f43 Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/500515 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
This repository contains code that serves pkg.go.dev/metrics.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/pkgsite-metrics:” in the subject line, so it is easy to find.