| commit | a76cee4d947186be1e24f699fa1b257a368ec687 | [log] [tgz] |
|---|---|---|
| author | Tim King <taking@google.com> | Thu Sep 12 16:30:13 2024 -0700 |
| committer | Tim King <taking@google.com> | Fri Sep 13 15:59:13 2024 +0000 |
| tree | 9983fcbbf58d5fb486d540e2fe0984f01fdb3d3f | |
| parent | e95c7975cf6960635835273d1c8774179a304c50 [diff] |
cmd/vulncheck_compare: missing error branch Execution continued when `err != nil` and `binResp == nil`. This was causing flakes on the LUCI builders Change-Id: Ib3f9086b8315fc36b72745900720a572f2fbecce Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/612915 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
diff --git a/cmd/govulncheck_compare/govulncheck_compare.go b/cmd/govulncheck_compare/govulncheck_compare.go index 72959c0..6a9b80a 100644 --- a/cmd/govulncheck_compare/govulncheck_compare.go +++ b/cmd/govulncheck_compare/govulncheck_compare.go
@@ -75,6 +75,7 @@ binResp, err := govulncheck.RunGovulncheckCmd(govulncheckPath, govulncheck.FlagBinary, binary.BinaryPath, modulePath, vulndbPath) if err != nil { pair.Error = err.Error() + continue } pair.BinaryResults = *binResp pair.BinaryResults.Stats.BuildTime = binary.BuildTime