Google Git
Sign in
go / pkgsite-metrics / 9593943f83ddfe78d270546c9a66955cd8b7a79a
commit9593943f83ddfe78d270546c9a66955cd8b7a79a[log] [tgz]
authorJonathan Amsterdam <jba@google.com>Mon Mar 06 16:28:02 2023 -0500
committerJonathan Amsterdam <jba@google.com>Tue Mar 07 02:01:11 2023 +0000
tree82528a0aceeba2ebeb8663bfa2e744f18504e0dc
parentf670a8649ee817d1e6ef4204b8b681bec266cbf1 [diff]
internal/bigquery: require SetUploadTime

Previously, bigquery.Client.Upload called SetUploadTime only
if a row implemented that method.

That resulted in a bug where analysis results did not have their
CreatedAt column populated.

Since we expect everything we write to BigQuery will be timestamped,
require the SetUploadTime method.

Change-Id: I7c499e0beff88d0d34a8bd1c95e6f8631cb9a348
Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/473777
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2 files changed
tree: 82528a0aceeba2ebeb8663bfa2e744f18504e0dc
  1. cmd/
  2. deploy/
  3. devtools/
  4. internal/
  5. static/
  6. terraform/
  7. .dockerignore
  8. .gitignore
  9. all_test.go
  10. checks.bash
  11. config.json.commented
  12. CONTRIBUTING.md
  13. go.mod
  14. go.sum
  15. LICENSE
  16. Makefile
  17. PATENTS
  18. README.md
  19. tools_test.go
README.md

pkgsite-metrics

This repository contains code that serves pkg.go.dev/metrics.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/pkgsite-metrics:” in the subject line, so it is easy to find.