internal/worker: do not propagate CompareModule errors

An endpoint should return an error only when we think this error is
transient, i.e., it might go away with a retry. Otherwise, a task can be
retried indefinitely which might clog the queue.

This is happening for compare mode. We log the error message for
visibility but we do not propagate it back. Note that in govulncheck
mode we save the error to the table, but this does not make sense for
compare mode.

Change-Id: I106d182406e12ffc17b84f9e98d60f3daa00f110
Reviewed-by: Jonathan Amsterdam <>
Run-TryBot: Zvonimir Pavlinovic <>
TryBot-Result: Gopher Robot <>
LUCI-TryBot-Result: Go LUCI <>
1 file changed
tree: fa50a23e311ba99f45759dc48b94c283d53bbc15
  1. cmd/
  2. deploy/
  3. devtools/
  4. internal/
  5. terraform/
  6. .dockerignore
  7. .gitignore
  8. all_test.go
  9. checks.bash
  10. config.json.commented
  12. go.mod
  13. go.sum
  15. Makefile
  18. tools.go


This repository contains code that serves

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see

The main issue tracker for the time repository is located at Prefix your issue with “x/pkgsite-metrics:” in the subject line, so it is easy to find.