| commit | 4f71cc8e1a38c6ced50eb9d0a6e6587a42c6f02c | [log] [tgz] |
|---|---|---|
| author | Zvonimir Pavlinovic <zpavlinovic@google.com> | Sat Nov 18 00:52:38 2023 +0000 |
| committer | Zvonimir Pavlinovic <zpavlinovic@google.com> | Mon Nov 20 15:57:45 2023 +0000 |
| tree | fa50a23e311ba99f45759dc48b94c283d53bbc15 | |
| parent | 33790070c31f9479a6dc6d32501ac6ae7670b1ad [diff] |
internal/worker: do not propagate CompareModule errors An endpoint should return an error only when we think this error is transient, i.e., it might go away with a retry. Otherwise, a task can be retried indefinitely which might clog the queue. This is happening for compare mode. We log the error message for visibility but we do not propagate it back. Note that in govulncheck mode we save the error to the table, but this does not make sense for compare mode. Change-Id: I106d182406e12ffc17b84f9e98d60f3daa00f110 Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/543455 Reviewed-by: Jonathan Amsterdam <jba@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repository contains code that serves pkg.go.dev/metrics.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/pkgsite-metrics:” in the subject line, so it is easy to find.