commit 1168a82e592f6eebcc607582dada327866f71c16
author Jonathan Amsterdam <jba@google.com> Sat Mar 18 09:08:32 2023 -0400
committer Zvonimir Pavlinovic <zpavlinovic@google.com> Sat Mar 18 20:46:27 2023 +0000
tree 00f92aa3eabdb42e085047600c125195511adde5
parent 8b712b34af833e2eda913bddb2c1ec9e73b615b8

internal/config: add BinaryDir

Make the directory in which we keep binaries a configuration parameter.

We decided to do this because it was hard to come up with a directory
for binaries that would work on both Cloud Run and locally.

Using /tmp is fine locally, but Cloud Run mounts something on /tmp,
so a docker image that writes files to /tmp will see those files
when executed directly with `docker run`, but not on Cloud Run.

In the Dockerfile, we use /app/binaries, and the sandbox bind-mounts
that to the same path. But that won't work locally because normal
users can't create top-level directories. Locally, a user can set
GO_ECOSYSTEM_BINARY_DIR, or let the binary directory default to
/tmp/binaries.

Change-Id: I128c5cece34ee0b4612dd879bd103d57e68d5484
Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/477475
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>