commit | 3c9c1f6d00e8761389cd2c50bc4179459d6320b5 | [log] [tgz] |
---|---|---|
author | Jin Qin <qinjin@google.com> | Mon Mar 11 22:50:33 2024 +0000 |
committer | Gopher Robot <gobot@golang.org> | Tue Mar 12 20:05:50 2024 +0000 |
tree | 34f8fb1a44d7d6c3340dfc3abbc6b09459e3f01d | |
parent | 5a05c654f92c675eb6bfe782f61b601b0efb77ea [diff] |
oauth2/google: fix the logic of sts 0 value of expires_in The sts response contains an optional field of `expires_in` and the value can be any integer. https://github.com/golang/oauth2/blob/master/google/internal/externalaccount/basecredentials.go#L246-L248 In the case of less than `0`, we are going to throw an error. But in the case of equals to `0` practically it means "never expire" instead of "instantly expire" which doesn't make sense. So we need to not set the expiration value for Token object. The current else if greater or equal is wrong. It's never triggered only because we are sending positive `3600` in sts response. Change-Id: Id227ca71130855235572b65ab178681e80d0da3a GitHub-Last-Rev: a95c923d6a5d256fa92629a1fcb908495d7b1338 GitHub-Pull-Request: golang/oauth2#687 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/545895 Reviewed-by: Shin Fan <shinfan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Cody Oss <codyoss@google.com> Reviewed-by: Cody Oss <codyoss@google.com>
oauth2 package contains a client implementation for OAuth 2.0 spec.
go get golang.org/x/oauth2
Or you can manually git clone the repository to $(go env GOPATH)/src/golang.org/x/oauth2
.
See pkg.go.dev for further documentation and examples.
We no longer accept new provider-specific packages in this repo if all they do is add a single endpoint variable. If you just want to add a single endpoint, add it to the pkg.go.dev/golang.org/x/oauth2/endpoints package.
The main issue tracker for the oauth2 repository is located at https://github.com/golang/oauth2/issues.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. In particular: