| commit | 1e695b1c8febf17aad3bfa7bf0a819ef94b98ad5 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Thu Oct 06 14:47:20 2016 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Fri Oct 07 18:00:02 2016 +0000 |
| tree | 05f7d64369ae7fc8877a72f847de5bef31ac4c52 | |
| parent | 3c3a985cb79f52a3190fbc056984415ca6763d01 [diff] |
oauth2: fix brittle test A change introduced in https://golang.org/cl/18692 expanded upon the errors returned by the json package to be more informative about where the error occurred. This breaks a test in oauth2 that relies on the exact form that an error takes. Fix this test by simply checking whether it passes or not. Fixes golang/go#17363 Updates golang/go#11811 Change-Id: I0062dc64fc1a8fd094b14ed1d0b21528edfbb282 Reviewed-on: https://go-review.googlesource.com/30600 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
oauth2 package contains a client implementation for OAuth 2.0 spec.
go get golang.org/x/oauth2
See godoc for further documentation and examples.
In change 96e89be (March 2015) we removed the oauth2.Context2 type in favor of the context.Context type from the golang.org/x/net/context package
This means its no longer possible to use the “Classic App Engine” appengine.Context type with the oauth2 package. (You're using Classic App Engine if you import the package "appengine".)
To work around this, you may use the new "google.golang.org/appengine" package. This package has almost the same API as the "appengine" package, but it can be fetched with go get and used on “Managed VMs” and well as Classic App Engine.
See the new appengine package's readme for information on updating your app.
If you don't want to update your entire app to use the new App Engine packages, you may use both sets of packages in parallel, using only the new packages with the oauth2 package.
import (
"golang.org/x/net/context"
"golang.org/x/oauth2"
"golang.org/x/oauth2/google"
newappengine "google.golang.org/appengine"
newurlfetch "google.golang.org/appengine/urlfetch"
"appengine"
)
func handler(w http.ResponseWriter, r *http.Request) {
var c appengine.Context = appengine.NewContext(r)
c.Infof("Logging a message with the old package")
var ctx context.Context = newappengine.NewContext(r)
client := &http.Client{
Transport: &oauth2.Transport{
Source: google.AppEngineTokenSource(ctx, "scope"),
Base: &newurlfetch.Transport{Context: ctx},
},
}
client.Get("...")
}