tree ea93e7eb5af686c37e7fe084756075f9d3a6d3f1
parent 60b3f6f8ce12def82ae597aebe9031753198f74d
author Nicholas S. Husin <nsh@golang.org> 1772490685 -0500
committer Nicholas Husin <nsh@golang.org> 1772492532 -0800

http2: do not retry RoundTrip after peer sends a stream protocol error

Years back, our HTTP/2 server implementation had a stream accounting bug
that would cause it to improperly report a PROTOCOL_ERROR. In response
to this, we modified our Transport to retry RoundTrip when a RST_STREAM
with PROTOCOL_ERROR was received from a peer.

At this point, this retry logic had outlived its usefulness. Instead, it
might cause issues, e.g. a client that sends a malformed request will
keep retrying repeatedly, despite there being zero chance for the
request to actually succeed.

Fixes golang/go#77843

Change-Id: Ic043723e3535f68f91db33d8f6bcd7fc2dbce856
Reviewed-on: https://go-review.googlesource.com/c/net/+/750720
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>