commit | e6a4aa30b6fabf7401de07625d5c2275524f1438 | [log] [tgz] |
---|---|---|
author | Tom Bergan <tombergan@google.com> | Mon Nov 27 17:03:34 2017 -0800 |
committer | Tom Bergan <tombergan@google.com> | Tue Nov 28 01:37:49 2017 +0000 |
tree | ad26eb36697dc0cb6dff645b14e8e28fe0fabd03 | |
parent | db473f6b236423f13eb55a9d65bc6e9fc9bd4e03 [diff] |
http2: fix leak in activeRes by removing activeRes AFAICT, activeRes serves no real purpose. It is used in just two ways: - To reduce the number of calls to closeIfIdle, which reduces the number of acquires of cc.mu when there are many concurrent streams. I dug through the CL history and could not find any benchmarks showing that this is necessary. - To avoid redundant calls to cs.bufPipe.CloseWithError(err) when a read loop is shutdown. This is unnecessary, since redundant CloseWithError calls are ignored. Since there isn't a good reason to have activeRes, the simplest way to fix the leak is to remove activeRes entirely. Updates golang/go#21543 Change-Id: I1d1d2dc6c946425a2772c8bf71436707021ac269 Reviewed-on: https://go-review.googlesource.com/80137 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.