commit | e18ecbb051101a46fc263334b127c89bc7bff7ea | [log] [tgz] |
---|---|---|
author | Luke Shumaker <lukeshu@datawire.io> | Tue Jan 26 21:43:45 2021 +0000 |
committer | Brad Fitzpatrick <bradfitz@golang.org> | Fri Feb 26 17:20:49 2021 +0000 |
tree | a97eef3ab261a35135623cbd2278976b3006a4d3 | |
parent | 39120d07d75e76f0079fe5d27480bcb965a21e4c [diff] |
http2/h2c: Respect the req.Context() When using h2c.NewHandler, the *http.Request object for h2c requests has a .Context() that doesn't inherit from the *http.Server's BaseContext. This is surprising for users of vanilla net/http, and is surprising to users of http2.ConfigureServer; HTTP/1 requests inherit from that BaseContext, and TLS h2 requests inherit from that BaseContext, but cleartext h2c requests don't. So, modify h2c.NewHander to respect that base Context, by way of the hijacked Request's .Context(). Change-Id: Ibc24ae6e2fb153d9561827ad791329487dae8e5a GitHub-Last-Rev: 821b2070f7eebf900bb2e45ec92d80699f99e80d GitHub-Pull-Request: golang/net#88 Reviewed-on: https://go-review.googlesource.com/c/net/+/278972 Reviewed-by: Liam Haworth <liam@haworth.id.au> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Trust: Brad Fitzpatrick <bradfitz@golang.org> Trust: Damien Neil <dneil@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.