commit da9a3fd4c5820e74b24a6cb7fb438dc9b0dd377c
author Moritz Fain <moritz@fain.io> Mon Oct 14 21:20:59 2019 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> Mon Oct 14 21:28:45 2019 +0000
tree 79c80bf2fb7bff3756ff85d553b773272fbe2f59
parent 2ba7206551d1ac8b6b8385d1b685d70e60895828

http2: make Transport.NewClientConn respect Transport.DisableKeepAlives

While in http/1.1 the `http.Transport.DisableKeepAlives` directive disallows re-usage of the connection, in http2 it's currently implemented as "close the connection as soon as possible" (when the connection is idle).

Fixes golang/go#33260

Change-Id: I5c167029062168f53a2cd15b5fbd19c1589cf175
GitHub-Last-Rev: e35ab6278d5118605aa6de48ea625c099a427f6e
GitHub-Pull-Request: golang/net#48
Reviewed-on: https://go-review.googlesource.com/c/net/+/187958
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

http2/transport.go

diff --git a/http2/transport.go b/http2/transport.go
index fb92984..42ad181 100644
--- a/http2/transport.go
+++ b/http2/transport.go
@@ -603,7 +603,7 @@
 }
 
 func (t *Transport) NewClientConn(c net.Conn) (*ClientConn, error) {
-	return t.newClientConn(c, false)
+	return t.newClientConn(c, t.disableKeepAlives())
 }
 
 func (t *Transport) newClientConn(c net.Conn, singleUse bool) (*ClientConn, error) {