| commit | d2e5035098b3de466b3d1632f4e8d2e6f9b69e33 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Tue Oct 05 12:46:59 2021 -0700 |
| committer | Damien Neil <dneil@google.com> | Tue Oct 05 21:50:30 2021 +0000 |
| tree | b2a92c24460c0f35a13d96b6c5c3993659742e06 | |
| parent | d4b1ae081e3b66345121fd3ad754b645ae798b07 [diff] |
http2: avoid race in TestTransportReqBodyAfterResponse_403. This test sends a request with a 10MiB body, reads a 403 response while the body is still being written, and closes the response body. It then verifies that the full request body was not written, since reading a response code >=300 interrupts body writes. This can be racy: We process the status code and interrupt the body write in RoundTrip, but it is possible for the body write to complete before RoundTrip looks at the response. Adjust the test to have more control over the request body: Only provide half the Request.Body until after the response headers have been received. Fixes golang/go#48792. Change-Id: Id4802b04a50f34f6af28f4eb93e37ef70a33a068 Reviewed-on: https://go-review.googlesource.com/c/net/+/354130 Trust: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.