commit | c63010009c802314a29324ce49987897f9838e29 | [log] [tgz] |
---|---|---|
author | Damien Neil <dneil@google.com> | Mon Sep 26 15:52:29 2022 -0700 |
committer | Gopher Robot <gobot@golang.org> | Thu Oct 27 16:40:07 2022 +0000 |
tree | 2df127c625365cba2312c9731e28512a4fb892e2 | |
parent | 0c1aede73a1abc0a223812105881847fbbee2224 [diff] |
http2: discard more frames after GOAWAY After sending a GOAWAY with NO_ERROR, we should discard all frames for streams with larger identifiers than the last stream identifier in the GOAWAY frame. We weren't discarding RST_STREAM frames, which could cause us to incorrectly detect a protocol error when handling a RST_STREAM for a discarded stream. Hoist post-GOAWAY frame discarding higher in the loop rather than handling it on a per-frame-type basis. We are also supposed to count discarded DATA frames against connection-level flow control, possibly sending WINDOW_UPDATE messages to return the flow control. We weren't doing this; this is now fixed. Fixes golang/go#55846 Change-Id: I7603a529c00b8637e648eee9cc4608fb5fa5199b Reviewed-on: https://go-review.googlesource.com/c/net/+/434909 Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Damien Neil <dneil@google.com> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: LI ZHEN <mr.imuz@gmail.com> Reviewed-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.