| commit | c690dde0001d31e2a1d8b57f9763890c01fb6db0 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Fri Jun 03 14:07:06 2022 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Tue Jun 07 02:02:51 2022 +0000 |
| tree | db3bc448da6ebb0e337d3e9b8365e0ad64f8fc13 | |
| parent | c960675eff93b7ce235fa4b1578d83fa48ea129c [diff] |
http2: remove arbitrary timeouts in server_test.go If the test gets completely stuck at these points, we will want a goroutine dump in order to debug the hang, which log.Fatalf will not produce (but a test timeout will). If the test does not get completely stuck (as on a slow or overloaded builder), then we should let it continue to run until the overall test timeout, which (unlike hard-coded constants) should already take the speed of the builder into account. As a side-effect, this also moves some t.Fatalf calls out of background goroutines and into the main test-function goroutines where they belong (see golang/go#24678). Fixes golang/go#52051. Change-Id: I37504081e6fdf0b4c244305fc83c575e30b7b453 Reviewed-on: https://go-review.googlesource.com/c/net/+/410096 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Damien Neil <dneil@google.com>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.