| commit | a5a99cb37ef4b68617775ab669177656090ab396 | [log] [tgz] |
|---|---|---|
| author | Marten Seemann <martenseemann@gmail.com> | Mon Nov 23 15:42:45 2020 +0700 |
| committer | Ian Lance Taylor <iant@golang.org> | Mon Apr 05 18:03:19 2021 +0000 |
| tree | fa702c3b2244679b57629b620cc774198ec32efe | |
| parent | 0fccb6fa2b5ce302a9da5afc2513d351bd175889 [diff] |
internal/socket: use interface not type assertions to infer a wrapped net.Conn's kind
When passing a wrapped connection to ipv{4,6}.NewPacketConn, calls to
ReadBatch will fail with an invalid connection error. This is because
NewConn performs a type assertion to determine the type (TCP, UDP, IP)
of the net.Conn.
In order to allow for wrapped connections to be passed to NewConn, we
can use an interface assertion that checks for methods on the net.Conn
that are unique to TCP, UDP and IP.
Fixes golang/go#42444.
Change-Id: I07cdb037829643f5cf4cd77105a772fcff8c4b2a
Reviewed-on: https://go-review.googlesource.com/c/net/+/271927
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Daniel Martà <mvdan@mvdan.cc>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.