9d8ef8d73b53840886e4a772c72f2b7d396cb37c - net

commit	9d8ef8d73b53840886e4a772c72f2b7d396cb37c	[log] [tgz]
author	David Symonds <dsymonds@golang.org>	Fri Mar 18 08:54:57 2016 +1100
committer	David Symonds <dsymonds@golang.org>	Sun Mar 20 20:34:16 2016 +0000
tree	280c1d753c4a7340d6bffa64c4e04cdf8713a92b
parent	35b06af0720201bc2f326773a80767387544f8c4 [diff]

context: Uniformly pass cancelCtx by pointer.

cancelCtx has an embedded sync.Mutex. This change causes an extra
allocation when creating a new timerCtx via WithDeadline, but that seems
minor when compared with better locking discipline. If it turns out to
be a problem, the whole cancelCtx struct can be flattened into timerCtx.

Addresses part of golang/go#14839.

Change-Id: Ie86ed1b63592b521aefde747d5fafcd49ac18178
Reviewed-on: https://go-review.googlesource.com/20840
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

context/context.go[diff]

1 file changed

tree: 280c1d753c4a7340d6bffa64c4e04cdf8713a92b