|author||Damien Neil <firstname.lastname@example.org>||Sat Sep 11 18:41:19 2021 -0700|
|committer||Damien Neil <email@example.com>||Fri Sep 17 22:17:30 2021 +0000|
http2: avoid blocking while holding ClientConn.mu Operations which examine the state of a ClientConn--notably, the connection pool's check to see if a conn is available to take a new request--need to acquire mu. Blocking while holding mu, such as when writing to the network, blocks these operations. Remove blocking operations from the mutex. Perform network writes with only ClientConn.wmu held. Clarify that wmu guards the per-conn HPACK encoder and buffer. Add a new mutex guarding request creation, covering the critical section starting with allocating a new stream ID and continuing until the stream is created. Fix a locking issue where trailers were written from the HPACK buffer with only wmu held, but headers were encoded into the buffer with only mu held. (Now both encoding and writes occur with wmu held.) Fixes golang/go#32388. Fixes golang/go#48340. Change-Id: Ibb313424ed2f32c1aeac4645b76aedf227b597a3 Reviewed-on: https://go-review.googlesource.com/c/net/+/349594 Trust: Damien Neil <firstname.lastname@example.org> Run-TryBot: Damien Neil <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Reviewed-by: Brad Fitzpatrick <email@example.com>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run
go get -u golang.org/x/net. You can also manually git clone the repository to
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.