commit 69d4b8aa71caaaa75c3dfc11211d1be495abec7c
author Meir Fischer <meirfischer@gmail.com> Mon Jan 02 15:58:43 2017 -0500
committer Brad Fitzpatrick <bradfitz@golang.org> Mon Jan 02 22:16:56 2017 +0000
tree bba9d4fa34858ebe1601ae39997985ecf980761d
parent 8fd7f25955530b92e73e9e1932a41b522b22ccd9

http2: remove unnecessary TODO for trailer keys allocation

strings.Join has two allocations:
(1) []byte intermediate
(2) final string conversion
The comma-separated keys are ultimately stored in hpack.HeaderField.Value
as a string so (2) is not wasteful. Because strings.Join is used so heavily
I assume its implementation is optimal - (1) is necessary.
Therefore, short of refactoring hpack.HeaderField's Value type, the status quo
seems optimal.

This TODO appears to have been copy-pasted from net/http/transfer.go
However, the two cases are different. transfer.go has two allocations
in addition to strings.Join: concatenation with literals and converting
string to bytes in io.WriteString.

Change-Id: I292203a6535dd2774f5bf45e7280b89aabb5d78d
Reviewed-on: https://go-review.googlesource.com/34626
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>