tree 603332c2864c3a500a0d0881c389faac7db8efe2
parent d64ee3fa515a813805f6ced54cea49bed2bd62b9
author Lars Lehtonen <lars.lehtonen@gmail.com> 1572030226 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1572219374 +0000

http2: fix test goroutine

This PR fixes the `TestTransportAbortClosesPipes()` test, which was calling `T.Fatal()` from inside a goroutine. `testing.T.Fatal()` is a convenience function that calls `testing.T.Log()` before `testing.T.FailNow()`.

From the godoc for `testing.T.FailNow()`:

>   FailNow must be called from the goroutine running the test or benchmark function, not from other goroutines created during the test. Calling FailNow does not stop those other goroutines.

Change-Id: I34d13fc5a14be8b00bee7eae590781bb1ef3ae55
GitHub-Last-Rev: c3929733c5ddbf6cbb41f403aae6ca9a664a48fb
GitHub-Pull-Request: golang/net#56
Reviewed-on: https://go-review.googlesource.com/c/net/+/203479
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>