commit | 53de4c7853b55ebf5ab449ccd99462cdf4db48de | [log] [tgz] |
---|---|---|
author | Lars Lehtonen <lars.lehtonen@gmail.com> | Fri Oct 25 19:03:46 2019 +0000 |
committer | Brad Fitzpatrick <bradfitz@golang.org> | Sun Oct 27 23:36:14 2019 +0000 |
tree | 603332c2864c3a500a0d0881c389faac7db8efe2 | |
parent | d64ee3fa515a813805f6ced54cea49bed2bd62b9 [diff] |
http2: fix test goroutine This PR fixes the `TestTransportAbortClosesPipes()` test, which was calling `T.Fatal()` from inside a goroutine. `testing.T.Fatal()` is a convenience function that calls `testing.T.Log()` before `testing.T.FailNow()`. From the godoc for `testing.T.FailNow()`: > FailNow must be called from the goroutine running the test or benchmark function, not from other goroutines created during the test. Calling FailNow does not stop those other goroutines. Change-Id: I34d13fc5a14be8b00bee7eae590781bb1ef3ae55 GitHub-Last-Rev: c3929733c5ddbf6cbb41f403aae6ca9a664a48fb GitHub-Pull-Request: golang/net#56 Reviewed-on: https://go-review.googlesource.com/c/net/+/203479 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.