tree 775c8ae1b26943970b073ecccb48c0bd96929304
parent 8ecbaa95fea823c19fa74c5c3b53e0bccd473828
author Nicholas S. Husin <nsh@golang.org> 1780076631 -0400
committer Nicholas Husin <nsh@golang.org> 1780524277 -0700

internal/http3: snapshot response headers at WriteHeader time

HTTP/3 currently buffers small body writes. As a result, if a server
handler modifies its headers after WriteHeader has been called, the
modified headers will be sent by the server as part of its response.
This behavior is generally unexpected and inconsistent with our HTTP/2
implementation.

Therefore, change HTTP/3 server to snapshot the headers at WriteHeader
time, to ensure that buffering responses will not result in different
headers being sent.

For golang/go#70914

Change-Id: Ie1ed44f2cfc3d60ac28d8bb64118bd846a6a6964
Reviewed-on: https://go-review.googlesource.com/c/net/+/784960
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>