| commit | 2ed6ce1e1725f5c20e0293e329871bddf557e436 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Fri Jan 21 10:54:57 2022 -0500 |
| committer | Bryan Mills <bcmills@google.com> | Fri Jan 21 17:51:14 2022 +0000 |
| tree | 1a9daa17f3cb876e8f96077d57662268050ec854 | |
| parent | 4395403b659ad054bd98ef027431ac3da1369d85 [diff] |
http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester This test constructed a new serverTester for each subtest, but reused a Transport across all of the tests. I don't fully understand why, but for some reason that occasionally led to "connection reset by peer" failures when the port was reused. Scoping the Transport to the lifetime of the serverTester seems to resolve the errors: I tested with go test ./http2 -run=TestContentEncodingNoSniffing -httptest.serve=127.0.0.1:8080 -count=10000 and got lots of failures prior to this change and none after. Fixes golang/go#46762 (I hope.) Change-Id: I385c077c1d8627e42ce4d2db041878aacb5452fb Reviewed-on: https://go-review.googlesource.com/c/net/+/380154 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.