| commit | 22bb95c5e783d192c577a7b310b06637db9f1d94 | [log] [tgz] |
|---|---|---|
| author | Brad Fitzpatrick <bradfitz@golang.org> | Wed Aug 01 17:57:41 2018 +0000 |
| committer | Brad Fitzpatrick <bradfitz@golang.org> | Wed Aug 01 18:34:31 2018 +0000 |
| tree | 310d2930ffa56836577d1a7b9e86cfabd4681e28 | |
| parent | 32f9bdbd7df18e8641d215e7ea68be88b971feb0 [diff] |
http2/hpack: lazily build huffman table on first use This generated 120 kB on the heap before at init, regardless of whether somebody used http2. Worse, because we vendored it into std, users would have two copies, for about 256 kB of memory. After CL 127235 that went down to 60 kB per copy, so 120 kB for a binary using golang.org/x/net/http2 explicitly. With this, it goes to 0 until one of the two copies in the binary actually uses one of the http2 packages. I wasn't able to measure any difference with the Once.Do in the decode path: name old time/op new time/op delta HuffmanDecode-4 732ns ± 8% 707ns ± 3% ~ (p=0.268 n=10+9) (admittedly noisy) Change-Id: I6c1065abc0c3458f3cb69e0f678978267ff35ea2 Reviewed-on: https://go-review.googlesource.com/127275 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This repository holds supplementary Go networking libraries.
The easiest way to install is to run go get -u golang.org/x/net. You can also manually git clone the repository to $GOPATH/src/golang.org/x/net.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html. The main issue tracker for the net repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.